Get raw field labels from app grids and tables#2426
Merged
labkey-tchad merged 26 commits intodevelopfrom May 2, 2025
Merged
Conversation
labkey-susanh
approved these changes
Apr 24, 2025
labkey-danield
approved these changes
Apr 25, 2025
labkey-danield
requested changes
Apr 25, 2025
Contributor
labkey-danield
left a comment
labkey-danield
left a comment
There was a problem hiding this comment.
I marked this as approved before realizing that there are several failures in LKSM and Biologics for this branch.
Can you get a cleaner run first?
Member
Author
Yeah, I flipped the lims PR to draft when I noticed the failures. I made a temporary change that ensures there is a double-space in every random field name and it uncovered some places that still need updates. |
labkey-danield
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
[Story] (Phase 2)
The browser modifies whitespace when rendering text (removing duplicate spaces and trimming leading/trailing whitespace). As such, we can't trust it to accurately represent field labels. Currently, we use
WebElement.getTextto extract field labels from the page which might not match a field's actual label. We should be able to extract accurate labels from the page via thetestContextproperty or by inspecting HTML text nodes. This will allow us to remove the multi-space restriction fromTestDataGenerator.randomNameandFieldDefinition.labelFromName.Related Pull Requests
Changes